Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TECH-84: [wp-conditional-blocks] Basic Conditions #75

Merged
merged 16 commits into from
May 6, 2024
Merged

TECH-84: [wp-conditional-blocks] Basic Conditions #75

merged 16 commits into from
May 6, 2024

Conversation

jakewrfoster
Copy link
Member

@jakewrfoster jakewrfoster commented Apr 24, 2024 •
edited
Loading

Summary

[wp-conditional-blocks] Basic Conditions add basic default conditions

Notes for reviewers

None.

Changelog entries

Added

  • a shortlist of "default" conditions
  • a select menu in the slotfill sidebar for selecting conditions added via filters.

Changed

  • logic in render function callback to align with new condition attribute.

Deprecated

Removed

  • logic pertaining to the previous method of adding a condition (including, conditions, query, post, index)
  • fields pertaining to the above from the slotfill sidebar

Fixed

Security

Ticket(s)

@jakewrfoster jakewrfoster linked an issue Apr 24, 2024 that may be closed by this pull request
Add some basic conditions to the plugin #18
Closed
@jakewrfoster jakewrfoster marked this pull request as ready for review May 1, 2024 18:59
@jakewrfoster jakewrfoster requested a review from mogmarsh May 1, 2024 18:59
scottnelle
scottnelle approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@scottnelle scottnelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👻

blocks/condition/edit.tsx Outdated Show resolved Hide resolved
src/class-conditions.php Outdated Show resolved Hide resolved
@jakewrfoster jakewrfoster mentioned this pull request May 1, 2024
Closed
mogmarsh
mogmarsh approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 👍

@jakewrfoster jakewrfoster merged commit 546dbd5 into develop May 6, 2024
7 checks passed
@jakewrfoster jakewrfoster deleted the feature/TECH-84/wp-conditional-basic-conditions branch May 6, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogmarsh mogmarsh mogmarsh approved these changes

@scottnelle scottnelle scottnelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add some basic conditions to the plugin
3 participants
@jakewrfoster @scottnelle @mogmarsh